Performance improvement: stop serving wrapper code (#179)

* Only serve react app in development

- Don't serve server code from "webpack serve"
- Don't serve iframe wrapper from "webpack serve"
- Update "basic" local test to load -impl file, not wrapper
This commit is contained in:
Elisha Nuchi
2023-03-10 14:43:48 -05:00
committed by GitHub
parent 50fc0de433
commit 7fd979aed8
10 changed files with 22 additions and 8 deletions
Binary file not shown.

Before

Width:  |  Height:  |  Size: 50 KiB

After

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 48 KiB

After

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 50 KiB

After

Width:  |  Height:  |  Size: 54 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 40 KiB

After

Width:  |  Height:  |  Size: 40 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 38 KiB

After

Width:  |  Height:  |  Size: 39 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 40 KiB

After

Width:  |  Height:  |  Size: 40 KiB

+3 -2
View File
@@ -29,7 +29,7 @@ const webpackDevServerReady = async (process) => {
console.log('Waiting for Webpack Dev Server to finish loading...');
return new Promise((resolve) => {
process.stdout.on('data', (data) => {
if (data.includes('DEVELOPMENT: CLIENT - Dialog Demo Bootstrap')) {
if (data.includes('CLIENT - Dialog Demo Bootstrap')) {
resolve();
}
});
@@ -56,12 +56,13 @@ describe(`Local setup ${isExtended ? '*extended*' : ''}`, () => {
if (isExtended) {
await openAddon(page);
} else {
await page.goto('https://localhost:3000/dialog-demo-bootstrap.html');
await page.goto('https://localhost:3000/dialog-demo-bootstrap-impl.html');
await page.waitForTimeout(3000);
}
});
afterAll(() => {
console.log('Closing process.');
process.kill();
});